fix(n8n): form visual builder field ordering (v2.0.1)#192
Merged
Conversation
- Move Type field first in fixedCollection values so displayOptions.show.type works - Disable ESLint sort rule for FormDescription.ts (its autofix strips displayOptions) - Fix README archive install URL to use tag-specific path - Bump version to 2.0.1
V1 Form node had no top-level `type` parameter (was hardcoded as `modal`). When SharedRouter maps v1 `createView` to v2 `create`, bodyMap tries to read `type` and throws "Could not get parameter". Added `default` support to FieldMap: when a bodyMap entry has a default value, getNodeParameter is wrapped in try/catch and falls back to the default. Form `type` field now defaults to `modal`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Typefield must be first infixedCollectionvalues so other fields can reference it viadisplayOptions.show.typedisplayOptionsand reorders fields alphabetically, breaking the builder)/releases/latest/)Root cause
n8n ESLint rule
node-param-fixed-collection-type-unsorted-itemsauto-sortsvaluesalphabetically bydisplayName, movingTypeto the end. It also stripsdisplayOptionsfrom sub-fields. Both changes break the Visual Builder since other fields depend ontypeviadisplayOptions.show.type.v1 node was not affected — it was frozen before ESLint was added.
Test plan
turbo buildpassesturbo checkpasses (lint + typecheck + knip + 409 tests)